Josefine Herlin
Josefine Herlin
This looks good to me, however I will leave the approval to the writers in the PX team 🙏🏼 cc @jacobhylen @Hannes7eicher @BenjaminDannegard
@Lenardgeorge what is the status of this tutorial? Do we still want to add it?
Hello @kerbinite ! Please sign the CLA so that we can review your PR properly ⭐ Thank you for your contribution!
Yes, sorry about that. The Cloudflare Pages action is an unfortunate name, it is really just creating a preview of the page - which in this case is no issue....
To me, it looks good, but the approval review should come from the maker content and pro content people, I've also tagged @jcarolinares here since there was one example from...
@per1234 we are waiting for the review of @jcarolinares before we merge, I think maybe that's why @jacobhylen didn't approve through the system :)
@per1234 it seems like there are some conflicts that need to be resolved before we can review and approve this PR, can you take care of them? 🙏🏼
And then we are also waiting for @jcarolinares's approval 🙏🏼
Hello @Lawrence4U and thank you for your opened issue! We are aware of the problem, and we're working on a solution. This will be solved as swiftly as we can...
@lukdog does this mean that the validations won't run on a "push to production" action but we'll still have them on PRs?