Joshua Gerrish
Joshua Gerrish
I just wanted to say thanks for the extensive back-and-forth in this PR, it's been helpful to other people. I've been testing adding SPI secondary (slave) support to avr-hal, and...
Hey. Thank you for this project. I was able to build it and work with pforth, great experience. I used cmake for the build, which is where I came across...
Your insight was correct Apteryks, it's a race issue. The create_document test in creator.rs creates a document called test_1_create.pdf The load_and_save test opens and loads this file, so it needs...
I've started work on this. One question. I'm storing the muted field in TTSSettings instead of TTSController so it can be persisted. I think this will require the settings file...
Thank you for laying out the original reasons and user needs. I'll use the controller session.
I bit off more than I can chew here, I wasn't happy with the version I came up with. If somebody wants to pick it up, that's cool. Thank you...
I'm sorry, upon further review of this PR, I realize there's a resource exhaustion bug in this code. If the user starts four game downloads, there won't be any threads...
PR is fixed up, I've started work on issue #367, but I wanted to submit the changes in manageable pieces. Thank you for taking the time to review this.
Fixed up the unit tests failing and added a comment about the reason. Thanks again for your time. Related, there's a single unit test that fails when run alone: python...
No problem. Thanks again for the great application and have a good week. Feel free to close this PR if you want.