jfhr comments

Results 8 comments of


                                            jfhr

Add type security for configuration files

Hi, I wanted to validate my config files so I made an [unofficial JSON schema file](https://gist.github.com/jfhr/181123d7acc87ea329be3700d9c37594). Example use: ```JSON { "$schema": "https://gist.githubusercontent.com/jfhr/181123d7acc87ea329be3700d9c37594/raw/9dafefb638f8ff0660930cc48debefa1dfcd87ca/lighthouserc.schema.json", "ci": { } } ``` Let me know...

why is the first argument to an http.Server's upgrade event listener called response?

Hey, I'll send a PR this evening.

why is the first argument to an http.Server's upgrade event listener called response?

Looks like I mixed up the two different upgrade events. In that case, this issue is obsolete. Sorry for the confusion and thanks Ipinca for clearing this up.

Update: HTTP_Headers_Cheat_Sheet

Hey thanks for the feedback, I've created a PR

Update: HTTP_Headers_Cheat_Sheet

this has now been merged :)

Add generic type for opaque object for stream() and pipeline()

Ok, I will send a PR for this

Missing </p> not detected. Is this a bug?

This is not an error, the `` is not required. This is specified in [the HTML standard](https://html.spec.whatwg.org/multipage/grouping-content.html#the-p-element): > A [p](https://html.spec.whatwg.org/multipage/grouping-content.html#the-p-element) element's [end tag](https://html.spec.whatwg.org/multipage/syntax.html#syntax-end-tag) can be omitted if the [p](https://html.spec.whatwg.org/multipage/grouping-content.html#the-p-element) element...

Node.js REPL freezes with "while (true);" or "while (true){}" input

I believe the issue is that the repl hangs when you type in `while(true);` **without pressing enter** (meaning the preview evaluation causes the hanging). It doesn't happen when running with...