Jérôme
Jérôme
Is there any plan to work on this one soon? If not, can I give it a try?
@jjspace any update on this one? 👀
Hi @jjspace ! I'll be off for one week starting from now with no connectivity at all... I'll catch up on oct 7th See you soon
Hi @jjspace, I'm back :grin: I've addressed most of your comments I think, but there are still some pending points... Tell me what should be the next step!
@jjspace @ggetz, I've rebased my branch and updated the CHANGES.md. I also tried to improve the way canAnimate is updated in the _onTick using a callback. The test "suspends animation...
> can I take this please? Sure !
Not really, in fact. I wanted to relate this PR to something similar, but the real motivation is to achieve the same effect as what you can see in Callback...
You're perfectly right: the `ReferenceFrame.INERTIAL` refers to the International Celestial Reference Frame, not to the entity's inertial reference frame. Would it be ok if I rename the `ReferenceFrame` enum like...
Or may be just create a new enum: ```javascript /** * Constants for identifying well-known tracking reference frames. * * @enum {number} */ const TrackingReferenceFrame = { /** * The...
Got it @ggetz ! You're right: EAST_NORTH_UP should be renamed AUTO_DETECT with a clear documentation of its behavior. Anyhow, my implementation of inertial tracking overrides this auto-detect behavior. Is that...