Jason Francis

Results 136 comments of Jason Francis

Maybe there should still be a `ListStore` without a type parameter to support ones with a runtime dynamic type? `ListStoreDynamic` or something? Or I can change this to `TypedListStore` and...

> Wouldn't that be `ListStore`? Not unless we want to relax `ListStore` to also be covariant on `T`. That can be done but it would be mean that `ListStore::insert` et...

In GTK there are some we know the type of which could be implemented manually with a type parameter: - `gdk::prelude::DisplayExt::monitors` -> `gio::ListModel` - `gtk::prelude::FileChooserExt::files` -> `gio::ListModel` - `gtk::prelude::FileChooserExt::filters` ->...

Unfortunately `model.type_().is_a()` or `value.is_type()` still can not type check the parameter with this approach, that should probably be documented somewhere to make it clear

I think this needs some adjustments to the `BoxedInline` macro since the stack allocated version should not implement `Copy` or `Clone` and probably not `to_glib_full`/`from_glib_full` either. Or it is probably...

> I can't apply any of those operations on my vector inside the array, because the operation doesn't mutate in place. You can mutate the array by doing `array[i] =...

@andy128k I'd like to see this updated with the latest bits from awesome-gtk (async stuff, lint fixes) and then I can review it, I've found this to be really useful

A couple more things: - I didn't bother tagging all of them because there's so many, but every usage of gio and glib inside a quote block should be fully...

Do we want to require an `#[action]` attribute on the method in order to make it an action? Without that attribute the macro would skip over that function. That's what...

Let me modify the example to show what I mean. Would it help to be like this: ```rust #[gio::actions] impl MyApplication { #[action] fn action1(&self) { /* this method gets...