John Estabrook
John Estabrook
Discussed in today's dev meeting: we need to evaluate whether any daemons are leading-white-space sensitive, and how easily leading white-space can be controlled during rendering.
I will echo Thomas' comment that this is very nice work; I am testing it in some current scenarios, and will update this PR with questions/feedback. Thank you!
This PR will be closed and replaced by: https://github.com/vyos/vyos-1x/pull/1515 Details in that PR.
I realize one error in my previous comment: you will want to handle the nexthop_group option in the raw output also --- the problem with that is that there is...
As mentioned in the previous comment, we will not make use of this as is, but will remain informed by the ideas contained.
@aidan-gibson you are correct that it applies only to those packages pinned in: https://github.com/vyos/vyos-build/blob/current/data/live-build-config/archives/trixie.pref.chroot hence needed independent of defaults.toml. Cf. https://vyos.dev/T5867; introduced in: https://github.com/vyos/vyos-build/commit/197feda60148ebeb907a457c1c6178926b403038
All smoketests passed in local tests.