Jess
Jess
I would like to contribute but I can't quite work out what the remaining issues are, is anyone still working on this?
> We already had motor_vehicle:backward/forward implemented and yesterday I implemented the maxspeed:backward/forward handling for car (#2727). > > The remaining bit is regarding lanes. Have a look into OSMLanesParser and...
I think the method should stay in the components file as it's more closely aligned with the other methods in that file whereas the io file is self-described as containing...
Thank you for your comments and input :-) I largely agree with the changes and agree that more tests should be written for it in the future
> before reviewing, I was thinking about a better naming. Perhaps `import_from_network` would be better aligning with the other import function names? how about "add_components_from_network"? Could also change the current...
> > > before reviewing, I was thinking about a better naming. Perhaps `import_from_network` would be better aligning with the other import function names? > > > > > >...
@FabianHofmann what's the reason for the failing tests? I can't work it out from the output
@FabianHofmann can this now be merged?
@FabianHofmann I've come across a bug: we need to change the method so that buses are added first (otherwise new components e.g. lines, which are attached to the new buses...
> @FabianHofmann I've come across a bug: we need to change the method so that buses are added first (otherwise new components e.g. lines, which are attached to the new...