Jeroen Visser

Results 30 comments of Jeroen Visser

This will be an optional thing, right? The current way of configuring may not be great for some, but being able to control the way configuration is fetched is vital...

I think this is ready for initial review: https://github.com/jeroenvisser101/growthbook-elixir https://hexdocs.pm/growthbook I'll be testing it in a real-world app more thoroughly later, but the library meets all test cases set out...

I think for now the questions I have are these: - Some fields (like tags, groups, status) are marked as `@deprecated` in the types (but not a proper TSDoc, so...

RE: type coercion, it may be good to include some of these edge cases to ensure that all libraries operate the same. I didn't see any failures there, but they...

@did I've tried to port changes from 7e4eacd to [the gem](https://github.com/locomotivecms/liquid-template-inheritance), but it doesn't seem to work. Instead, the tests throw `Liquid::SyntaxError: Liquid syntax error: 'extends' tag was never closed`,...

@did thanks! I'll have a look at that for sure. My best outcome would be to get it working with the 'original' version of liquid, and to get it working...

How about making a new one and publishing to both, abandoning (possibly with deprecation warnings to STDOUT) the old?

@adomokos thanks — I haven't tested that yet, but in theory, it should work.

perhaps you could split words with double dash (`--`) or with an underscore (`_`) to make it clearer?

I think it's not only the deviceIds itself, but the number of them, and it allowing to fingerprint the device. For instance, on the browserless/base image, the number of mediaDevices...