Jacob Deichert

Results 8 comments of Jacob Deichert

Hey Scott, I ran through every component/page and nothing broke in obvious/visible ways. Just the "Code" tab crash I mentioned above, as well as @taylorvnoj's observations 👍

👋 Closing this for now! When we get back to the vs code extension, Scott has found a library that gathers all props for components (part of new docs site),...

> If Storybook ends up being a blocker here btw, let me know. We've been looking for an excuse to start moving away from our custom-built Storybook 7 experience towards...

@Aiden-Brine I'm not seeing that 🤔 I tested both light and dark mode. Are you clearing your vite cache between rebuilds by chance?

Discussed with Scott offline. We can't load components from src right now. I broke out all of the type import cleanups here: https://github.com/GetJobber/atlantis/pull/2670

@KyleKreutzer thanks for the PR! As Zak noted above, we have some FUD to figure out here... so we're creating a ticket for this work and we'll investigate how safe...

Closed in favour of https://github.com/GetJobber/atlantis/pull/2631

> One minor suggestion (about the file that was not included in this PR): > > * We can remove `| null` as a type option in [packages/components/src/Modal/Modal.types.ts](https://github.com/GetJobber/atlantis/pull/2821/files#diff-f009d2ba20d95e75c95832827c08a64993689bd4b5caa661b12dde7980527f02) Yeah, typescript...