Joe Darcy

Results 59 comments of Joe Darcy

> I've run all tests we have and not too surprised they pass since the affected values probably aren't being exercised. > > However I've been reading the docs about...

@merykitty, the proposed change is functionally correct. @cl4es, what set of platforms do we usually consider for evaluating performance changes like this?

> Also worth observing is there already being several overrides of com.sun.tools.javac.code.Types.MapVisitor#visitType where the idempotent return is unsuitable. So it seems the present problem also should simply override and handle...

> FWIW I did some testing with the current version of the patch, and didn't see any compatibility impact. Thanks for the testing Liam. Completing this patch has gotten swapped...

@vicente-romero-oracle , can you review the CSR for this? Thanks.

If not already planned, I recommend a much broader discussion/announcement of this test before it goes back. For example, a message to jdk-dev stating "The value of `@since` tags will...