Jack Dai

Results 9 comments of Jack Dai

One solution might be to still generate the "overriden" target (`:com_google_inject_extensions_guice_multibindings` in this case): ``` jvm_import( name = "com_facebook_nifty_nifty_core", jars = [...], srcjar = "...", deps = [ ":io_airlift_log", ":io_airlift_units",...

We can work around this by exporting the custom dependencies. This is not ideal for all cases though.

One potential solution is to expose a provider (maybe `PlusOneDeps` itself) so that custom rules can report their direct dependencies.

Consider a custom rule `my_java_rule` with a `custom_dep` attribute: ``` def my_java_rule_impl(ctx): ... java_info = java_common.compile( ctx = ctx, source_files = ctx.attrs.srcs, deps = [ctx.attr.custom_dep[JavaInfo]], ... ) return [java_info] ```...

It looks like we can workaround with: ``` override_targets = { "org.apache.hadoop:hadoop-yarn-server-tests": "@maven//:org_apache_hadoop_hadoop_yarn_server_tests_tests" }, ```

Those look like relative paths to me? I think the PR description was edited/redacted, which might be confusing now. But the original paths look something like: ``` /home//.cache/bazel//execroot//external/com_github_jetbrains_kotlin/lib/kotlin-stdlib.jar ``` Note...

+1, the reason we want this is because we want caches to persist across MacOS upgrades. So wiping it on reboot would be a step in the opposite direction.

Fixes https://github.com/spacedentist/spr/issues/200

It looks like the new documentation is here: https://spacedentist.github.io/spr/