Justin Klaassen

Results 11 comments of Justin Klaassen

> This should also be supported in `brew outdated`, which also has these options. Added in latest update.

FWIW, the existing code does handle when multiple options are specified (e.g. `brew upgrade --greedy --greedy-auto-updates --greedy-latest`). https://github.com/Homebrew/brew/blob/7848bd32269d5fcfecc00aeb142db426b9896ed6/Library/Homebrew/cask/upgrade.rb#L79-L90 If separate env vars are preferred I have a patch ready to...

Based on my understanding of the discussion it seems the generally preferred approach would be: 1. Change `--greedy` to accept 3 options: `all`, `latest`, `auto-updates`. 2. Make `-g` and `--greedy`...

I spent some time working on this but ran into a few implementation details that require some input: 1. Which format is preferred: "--greedy=all" or "--greedy all"? The former format...

Are you okay getting rid of `-g` and `--greedy` (i.e. force users to switch to `--greedy all`)? Doing `flag "--greedy="` will create an option with `RequiredArgument` type, which means `OptionParser`...

I'm happy to update my pull request with any preferred approach. Do you have a preference between adding `HOMEBREW_UPGRADE_GREEDY_AUTO_UPDATES` or modifying `HOMEBREW_UPGRADE_GREEDY`? If the latter, would it be backwards compatible...

Updated #16736 to modify `HOMEBREW_UPGRADE_GREEDY` as requested.

What's the best solution here? 1. Removing the uninstall script? (e.g. https://github.com/jck112/Homebrew-homebrew-cask/commit/20a9ac8) 2. Adding a parameter to allow casks to skip uninstall on upgrade (e.g. `skip_uninstall_on_upgrade true`)? 3. Adding a...

Okay thanks, I went ahead and uploaded #167500 to remove the uninstall script.

This may be more complicated than originally thought. It seems some of the paths and bundle ids have changed since the cask was originally created. There is now an additional...