João Carreira
João Carreira
Hi Tom, thanks for the comment. At the moment I'm the only one on this. I will try to go over as many of your comments as possible (and your...
It seems there is an issue with travis: ``` In file included from [01m[K./Tasks.h:9:0[m[K, from [01m[Kparameter_server.cpp:2[m[K: [01m[K./PSSparseServerInterface.h:19:48:[m[K [01;31m[Kfatal error: [m[Kcommon/schemas/PSMessage_generated.h: No such file or directory #include "common/schemas/PSMessage_generated.h" ``` Can you...
We agreed during the Tuesday meetings that it would be better to donwload the datasets from S3 instead of putting them in the github.
I suggest we create a new PR with the style changes.
Please fix this conflict. After that I will do a few more tests so hopefully we can merge this soon.
Please fix conflicts.
Let's change the code to allocate/deallocate that memory (using smart pointers). It;s safer that way.
Please fix the conflict
On hold until #65 gets merged.