jbsgh

Results 9 comments of jbsgh

Use lua_Integer instead of lua_Number for checksum calculation

lua_isnumber will not work correctly with 32-bit operations, as I stated in my OP.

myrand() in benchmark.c on big-endian causes rsa key generation to loop

At first sight, the values look good. But there's a subtle new issue in your proposed implementation: The values cycle every 256 calls of rand(). Consequentially, myrand( NULL, buf, 128...

myrand() in benchmark.c on big-endian causes rsa key generation to loop

But they do! Our C-runtime seems to use a simple LCG as rand() (I don't know how it's implemented on our embedded system in detail). Consider the following demo randtest.c:...

myrand() in benchmark.c on big-endian causes rsa key generation to loop

@irwir: The LCG was just intended as a demo. We're all aware that this kind of pseudo-random numbers have limitations. Obviously, implementations like this one can be found in real...

myrand() in benchmark.c on big-endian causes rsa key generation to loop

BTW: An improved test would be `#if (RAND_MAX >= 0x00FFFFFF)`. This condition ensures that the value of rand() shifted right by 16 bits covers the full range of an unsigned...

myrand() in benchmark.c on big-endian causes rsa key generation to loop

https://github.com/Mbed-TLS/mbedtls/pull/10492

[3.6] Pr for issue 10434

I've branched tag v3.6.4 for preparing the PR

[3.6] Pr for issue 10434

Done. @mpg: Reminder!

[3.6] Pr for issue 10434

What do you want me to do in detail? Please specify the requested git commands to fix your CI issues on the PR.