Jordan Borean

Check for Powershell files

3

Currently ansible-review will fail if we run the standard flake8 check on powershell files. As there is no standard set right now for how to handle PS scripts I am...

Remove uneeded become cleanup code

2

##### SUMMARY This code is no longer needed as it's covered by individual become plugins itself. ##### ISSUE TYPE - Feature Pull Request ##### COMPONENT NAME action

task executor not checking become changes on active connections

9

### Summary The code that checks the connection + become details in a loop is not applying the become state on connections that have the `connected` attribute set to `True`....

ansible-config - dump/list galaxy servers

5

##### SUMMARY Adds support for listing or dumping galaxy server configuration entries using the `-t galaxy_server` or `-t all` "plugin type". Fixes: https://github.com/ansible/ansible/issues/63288 ##### ISSUE TYPE - Feature Pull Request...

pvpanic, qemufwcfg, and qemupciserial are self signed with a bad basic constraint

8

**Describe the bug** The drivers for `pvpanic`, `qemufwcfg`, and `qemupciserial` in virtio-win 0.1.217 are signed with a self signed certificate. As well as this it has a CA constraint set...

The `-PSDeployTypePath` option in `Invoke-PSDeploy` didn't seem to do anything. This PR allows someone to specify a custom `PSDeploy.yml` file that sits outside of the module path and to load...

Markdocs docs with embeded autodoc fails to create valid links

2

### Describe the bug **context** When I have an embedded autodoc entry in my markdown file for myst to build, any references in the docstring are rendered invalid. Was initially...

-Fix adding UTF-8 BOM to files

4

Steps to reproduce ------------------ Create a file with a fixable violation ```PowerShell Function Test-Function { param ( [String] $Password ) $Password } ``` Run `Invoke-ScriptAnalyzer -Path ./file.ps1 -Fix` to fix...

PSUseConsistentWhitespace CheckInnerBrace - false positive on hashtable closing brace

1

Steps to reproduce ------------------ Create a settings file with ```PowerShell @{ Rules = @{ PSUseConsistentWhitespace = @{ Enable = $true CheckOpenBrace = $true CheckInnerBrace = $true } } } ```...

NTLM Negotiate Domain and Workstation Encoding and Offset is incorrect

11

**Describe the bug** The `Workstation` and `Domain` fields in the [NTLM NEGOTIATE_MESSAGE](https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-nlmp/b34032e5-3aae-4bc6-84c3-c6d80eadf7f2) should be encoded according to the OEM codepage and not UNICODE. > If DomainNameLen does not equal 0x0000,...