Jan Borchmann comments

Results 22 comments of


                                            Jan Borchmann

Make SparkCompare.report return string

I'd be also supportive of this change!

Make SparkCompare.report return string

One compromise could be to leave the spark report function mainly as is but in addition also add the string to be returned at the end.

Inequality when comparing two empty numpy arrays

So technically two empty dataframes should be equal. Maybe we could return `True` and a log message?

Inequality when comparing two empty numpy arrays

So what Simon really wants is elementwise comparison of the arrays, right?

Inequality when comparing two empty numpy arrays

I guess we would want to use something like [the numpy function](https://numpy.org/doc/stable/reference/generated/numpy.array_equal.html?highlight=array_equal#numpy.array_equal) to compare arrays.

Support multiple questrade accounts with different tokens

Thank you for raising this. I will need to think how to do this best given I would need to connect the yaml files to the specific class instances. Shouldn't...

Unclosed socket when doing testing with unittest

Hey! Thank you for opening the issue! Happy to add this, but I am not sure if I'll get to this before the weekend. I'd also be happy to review...

oauth2 token only works once

So I think you should be using the `refresh_access_token`-method to get a refreshed token. The API-docs for the method can be found [here](https://jborchma.github.io/qtrade/api/qtrade.html#qtrade.questrade.Questrade.refresh_access_token).

oauth2 token only works once

Closing this as I assume my reply solved the issue.

"400 Client Error: Bad Request for url" when using "get_historical_data"

Hmm, that is so odd. I will take a look tonight.