Jb Evain

Results 105 comments of Jb Evain

I'm not quite sure where to start here. Do you have a failing test case? An assembly that doesn't round trip properly?

But yeah, I was debugging the other day and noticed that ElementType.None was used for «we don't know, probably a class» at different places, which isn't great. Might not be...

I see. Yep, that definitely needs fixing. The fix is not to change `MetadataResolver.AreSame`, are Var and String are well, not the same :smile_cat:. Rather, GetOriginalMethod should check that the...

Yeah you're going to need to give more details, I'm not going to download and run a random test exe :)

@CreateAndInject thanks for looking into it. Could you please submit a PR with the fix and a test? What @atsushieno means is that everyone is busy, if you want developers...

> That sounds like a lot of work to make sure it's all tracked correctly, with a potentially major impact. Yeah, that one is not going to be fun. Need...

I think that's ok for now, they'll be roundtripped and preserved as a BinaryCustomDebugInformation.