Jason Bedard
Jason Bedard
Note the current test failure seems to be because the median test run is faster then expected? See [poll_spec.ts](https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/src/builders/browser/specs/poll_spec.ts)
Yeah we'd still like to do this one. I had I think all but one test green but have been working on https://github.com/angular/angular-cli/pull/23074 instead lately.
@alan-agius4 there is one TODO left here but I think this is worth landing as-is for now. WDYT?
The flakyness of these tests is very odd, and I think a lot of it has nothing to do with this change. Things like `@angular-devkit/core` not being found errors 🤔
@alan-agius4 we'd like to merge this as-is without actually enabling the multiple versions and just setting up the toolchains + BUILDs. It seems like these tests are very flaky and...
rules_js only reads the pnpm lock file and actually has no pnpm binary. The lockfile is also what makes pnpm deterministic which is essential.
Now that we have Greg's changes I'll give it a shot 👍
@gregmagolan this is passing now and ready
I think this is difficult because `NODE_PATH` must be absolute and until runtime we really have no idea where that will be (in the sandbox etc). You can set it...
I've updated the commit message a bit (and rebased). Let me know if there's other information you think should be in there.