Jakob Zahn

Results 17 comments of Jakob Zahn

> Maybe we should let the user deal with index conversion manually when dealing with these kinds of characters? This should be fine when the user knows that the index/slice...

Something else crossed my mind: Instead of converting the indices via `len(...encode()/decode())` on every change, one could maintain and update an array with chunk ranges. Thereby, the index given to...

Okay, so how about turning https://github.com/python-websockets/websockets/blob/76f6f573e2ecb279230c2bf56c07bf4d4f717147/src/websockets/asyncio/client.py#L523-L527 into ```python self.logger.info( "! connect failed; reconnecting in %.1f seconds", delay, ) self.logger.debug(exc, exc_info=True) # or similar ``` With that, we would have a...

> I started standardizing on "all DEBUG and ERROR logs have tracebacks; none of the INFO and WARNING logs do". Ah, okay, so my enhancement request would be covered by...

> I also understand that without concrete user interest in that feature it's reasonable to close a ticket like this. I also have great interest in this feature, for the...

> I see two main options: I would go for option 2 for now. > What API would you suggest and why? (The following is all untested.) How about that:...

> Do you think that this proposal would support your use case? Yes, the logic definitely would. I like it. :+1: With that callable, I have the options to either...

> Code changes are getting pretty minimal at this point ;-) My favorite :grin: > [...] the semantics of `process_exception` [...] I definitely see your point. Personally, I barely wrote...

> While thinking about this, something else crossed my mind: `process_exception` could return a dictionary with updated keyword arguments for the new `websockets.connect` initialization. 👀 > Wouldn't that be nice?...