Jan Prieser

Results 13 comments of Jan Prieser

the problem is here: https://github.com/schmittjoh/JMSDiExtraBundle/blob/master/Metadata/Driver/AnnotationDriver.php#L140 for some reason, annotations are only used from the service class itself. this is annoying for traits with annotated setters also. maybe @schmittjoh knows, why...

@schmittjoh fixed the indentation issue. travis fails for the same reason, the master branch failes. Its a composer issue: "Your requirements could not be resolved to an installable set of...

@molchanoviv the factory\* properties are integral part of a service definition in symfony. Be it in the PHP Interface, the YML Config or the XML Schema. Therefore they belong to...

@Ener-Getick, I just rebased. thanks for taking care!

just tested this with 15.7.2 and the issue still persists.

The release notes of 3.1.63.0 (https://www.here.com/docs/bundle/maps-api-for-javascript-release-notes-3.1.63.0/resource/Maps_API_for_JavaScript_HLP_v3.1.63.0_Release_Notes.pdf) state: ``` Following the announced end-of-life of the HERE Location Services that are outside of HERE platform, the following measures have been implemented: With...

@joyfulelement this client is different from the es6 client. simply adding flow annotations didn't work with the current code. The code is written in ES6 with flow syntax. In order...

Hi @wing328, this PR introduces a new javascript language dialect, please advise how to proceed with reviewing this changes.