Jay Conrod

x/exp/cmd/gorelease: split release, diff functionality and prepare to merge into GOROOT

1

@jadekler and I spent some time talking today about the future of gorelease. Here's what we're thinking. * There seem to be two diverging use cases: 1) checking whether the...

Expose generated Go files to editors and IDEs

132

When a library is created with `go_proto_library` or some other mechanism that generates Go code (.pb.go files in this case), the generated sources files are not exposed to editors and...

Windows tests that require protoc are failing in CI

2

For example: https://buildkite.com/bazel/rules-go-golang/builds/2117#f1a36175-f7c1-4cc4-bf93-6ccfc57a428d ``` (21:45:54) ERROR: C:/b/5nywwchv/external/com_google_protobuf/BUILD:311:2: Couldn't build file external/com_google_protobuf/source_context_proto-descriptor-set.proto.bin: Generating Descriptor Set proto_library @com_google_protobuf//:source_context_proto failed (Exit -1073741515): protoc.exe failed: error executing command --   | cd C:/b/5nywwchv/execroot/io_bazel_rules_go   | SET...

Move Gazelle extension to //gazelle/bzl and change package name

5

This fixes an issue with importing bazel-skylib into google3. Currently, Glaze (internal Go build file generator) attempts to generate a target (//gazelle:gazelle) that conflicts with one that's already declared here....

Extract canonical import path from .go files

1

Migrated from bazelbuild/rules_go#874 See https://golang.org/doc/go1.4#canonicalimports Go implementation: [`findImportComment`](https://github.com/golang/go/blob/46c5856f6dfcc76e00f753387ea3dc276de2b28e/src/go/build/build.go#L933)

Add directive to skip generating a specific rule

10

Migrated from bazelbuild/rules_go#788 For example, you could prevent Gazelle from generating a test for in a certain package using a directive like this: ``` # gazelle:skip go_default_test ```

Investigate migrating documentation to Stardoc

2

[Stardoc](https://github.com/bazelbuild/stardoc) is a documentation generator for Bazel rules, providers, and other definitions. Currently, Gazelle documentation is maintained separately from the implementation, so it's easy for it to drift. We should...

Don't recurse into directories referenced by local_repository

2

Bazel allows subdirectories within a workspace to be treated as external repositories with by referencing them with `local_repository`. This is useful for vendoring repositories that already have build files; import...

Support multiple packages in the same directory

2

(Originally bazelbuild/rules_go#315) We should consider supporting projects with multiple Go packages in the same directory. "go build" does not allow this, but it is fairly common within Google, and some...

cmd/dist: remove precompiled .a files from binary distributions

26

The downloadable archives at https://golang.org/dl/ currently contain precompiled .a files for all packages in the standard library. Each archive has a set of .a files for one platform, plus another...