Jayam Patel

Results 117 comments of Jayam Patel

Yup, I have checked it yesterday. Currently there are issues with dev-server starting in prod environment, once do will commit changes. Thanks @jnvtnguyen for looking.

@Shriyam-Avasthi It's strange .git isn't copied in Docker container, could you please rebuild it by following. 1. `make clean` 2. `make build` Also, can you tell in which system this...

@Shriyam-Avasthi I have confirmed bug occurs in WSL, thanks for bringing it. Being busy, I need some time to find proper fix to it. But till then I found temporary...

@Shriyam-Avasthi Sorry for inconvenience. Could you please help me by performing following steps. 1. `make run-devserver` to start container 2. `docker compose exec -it dev-server /bin/bash` it start bash in...

@Shriyam-Avasthi I have created seperate issue for it, could we continue over there.

@gp201 PTAL at [comment](https://github.com/oppia/oppia/pull/19962#discussion_r1528498281), need your response before I can move forward on it.

@seanlip, @StephenYu2018 Could you review implementation of fixing google module for docker made in [commit here](https://github.com/oppia/oppia/pull/19962/commits/06eb01c080bfa8b4756f5ccbaab59b697e37db9d). I will add backend tests if approved. An alternative would be to call install_third_party_libs.main()...

> @jayam04 I believe there is still one prior concern about a `browser.pause` statement in an E2E test file that hasn't been addressed yet. It is the only thing stopping...

@seanlip replied to review [here](https://github.com/oppia/oppia/pull/19962#discussion_r1568768646).

@seanlip, @StephenYu2018 Some tests are still failing, should I use browser.pause() over there too and create a new issue for same.