javalsai
javalsai
Not sure if it is because of this, but assuming that the cover is a `jpg` isn't probably a good idea. https://github.com/SwapnilSoni1999/spotify-dl/blob/09b803f4225e7d85e5304e220ae90fabaa8b787e/lib/metadata.js#L8-L31
@phyzical I see that for audio download you use ffmpeg to make sure of the format, as far as I know ffmpeg also works with images, so I'm giving it...
Seems to be working, I'll download a full playlist and if it does work I'll open a PR
> there was also this pr i made to attempt to fix it, though its a more of "okay lets try again" might aswell chuck these changes in with yours...
Should I convert this PR to a draft??
@phyzical It was probably that not all images were on the same format, and saving them as jpg caused weird things
> Will merge afterwards > extremely sorry for being late Don't worry about being late. > Just give a look to conflicts please They should be solved now
I tried to fix this by preferring the download of songs with a the duration more close to the original song from spotify. I did it in [my own fork...
@phyzical yes, I ended up including more factors like the channel name... and giving more "points" according to them. The problems come with songs like "Fluorescent Adolescent - Artic Monkeys"...
> Similar Issues: > > 1. [Instagram not found please make and update about it .](https://github.com/sherlock-project/sherlock/issues/977) > > 2. [Does Sherlock really supports Instagram?](https://github.com/sherlock-project/sherlock/issues/1816) > > 3. [story](https://github.com/sherlock-project/sherlock/issues/1807) > >...