Justin Kaeser

Results 87 comments of Justin Kaeser

Currently in IntelliJ `buildTarget/testClasses` is requested completely independently from compile tasks, afaik. @samvel1024 might know the details. But I agree this behavior makes sense.

Agree @olafurpg . Instead of closing I've added it to a backlog milestone

Agree we should have this. If the build tool is watching its own sources, however, it can send a [`buildTarget/didChange`](https://build-server-protocol.github.io/docs/specification.html#build-target-changed-notification) notification to tell the client to reload.

Yes, not fixing this was an oversight that I've been procrastinating on fixing ever since I noticed it after we changed `SourceItem` ... The problem now is that changing `ResourcesItem`...

Yup, I was thinking that, though it would duplicate some data. But it would keep the implementations simpler.

I've already pushed a fix for the Scala plugin so that it works with both file URIs and paths. I think really this should be an URI for consistency, but...

It's correct that IntelliJ assumes only one BSP connection file will be used for one `.bsp` directory, so your use case is currently not supported. In principle it would not...

Unspecified, and at the moment clients ignore this. Let's go with `application/json-rpc` as per the [JSON-RPC spec](https://www.jsonrpc.org/historical/json-rpc-over-http.html#http-header): > Content-Type SHOULD be 'application/json-rpc' but MAY be 'application/json' or 'application/jsonrequest'

Good point. On the website it looks like it's [not specified](https://www.jsonrpc.org/specification) but `application/json` seems to be what people are using so let's go with that.

In principle I agree, but I'm not clear on the specifics - wouldn't a dependency resolver look different depending on the language ecosystem and even particular tool (e.g. maven vs...