Jason B. Cox

Reduce string allocations and copies in UniValue::write()

1

With this patch applied to Bitcoin ABC, we're seeing roughly 4% perf improvements where UniValue is used: https://reviews.bitcoinabc.org/D5982

Incorrect error message given for named inputs when unnamed input provided to fit()

2

While trying to author a subclass of PyDataset, I found that `__getitem__()` must return a dictionary with named values, otherwise an unrelated error is given. In hind sight, this is...

Unsigned transactions cannot be parsed by bitcoind

5

#### Steps to reproduce 1. Setup a transaction in ElectrumABC 2. Preview the transaction (do not sign it) 3. Click 'Copy' to copy the raw tx to clipboard 4. `bitcoin-cli...

I get this message on every shutdown: ``` INFO:stem:Error while receiving a control message (SocketClosed): received exception "read of closed file" ``` It seems harmless, but annoying nonetheless.

Compress NodeInfoLite bools into a bitfield

5

# What does this PR do? > [Related Issue Meshtastic#6427](https://github.com/meshtastic/firmware/issues/6427) This PR proposes to squash 3 bytes into 1 and allows up to 5 new boolean flags "for free." This...

Unexpected warnings presented for default masking behavior

1

**Describe the bug** UserWarnings are presented when a mask is propagated via mask_zero=True to TransformerDecoder. Considering this is the default behavior, a warning is confusing and a nuisance. **To Reproduce**...

maxAmountRequired appears misnamed

7

The naming `maxAmountRequired` is confusing. Normally payments require a minimum and overpayment is not undesirable for a service provider. A more appropriate name is `minAmountRequired`. I only hesitate to open...

This makes the code easier to read and more robust against regressions by avoiding duplicate changes to both code paths. The early return in the Curve25519 path also makes it...

The only hint at supported nodejs versions is that 12 is used in the Github workflows, but support for 12 ended in 2020. It would be great to know what...

package.json has `"main": "index.js",` but `index.js` does not appear to exist. If I had to hazard a guess, it looks like `js/validation.js` should be the default import, but it's unclear....