Jarvis Lin

Results 7 comments of Jarvis Lin

@antonis Thank you so much for reviewing this PR. I've update the missing icons and reverted all changes to strings except for the main strings resource.

> Awesome work @jarvislin 🏅 The code changes look consistent to me and the app behaved as expected in my tests. I've tested both the Jetpack app and the WordPress...

I think it is related to race condition because we have multiple tabs which might access the database at the same time.

> Thank you so much, Jarvis, for extracting fragments for notification and site comment details. Great work! 🎸 > > Since the original `CommentDetailFragment` is really large, I would encourage...

Thank you both for reviewing this PR!

**Update** I don't think the approach is the most suitable solution. I checked out https://github.com/terrakok/kmp-awesome#-test, and most of them **don't support Kotlin 2.0.0**. 😢 I'd like to hold off for...

Hi @erawhctim, > Why not have the ViewModel fetch data directly from a repository instance? (Aside from "because clean code says so", of course) This is simply my preference. From...