Jared Lockhart
Jared Lockhart
@shell1 One thing we realized is sticky targeting must be required for any first run targeting, so that messaging doesn't exactly work. What do you think?
@Martin-Robert Can you describe in more detail what exactly you mean by 'policy'?
@yashika-khurana Oh no that's the correct behaviour, that's not what I was seeing when I tried it, let me try it again.
Okay I see this is actually a bug right here: https://github.com/mozilla/experimenter/blob/51d02c7f82d88593434b175269a9a04d6c1c7b2d/app/experimenter/kinto/tasks.py#L380-L383 When leaving Preview back to Draft, the record should be deleted and `published_dto` should be set back to None,...
Just caught this locally: ```py In [25]: client.delete_record('asdf') INFO 2022-06-07 20:20:39,297 kinto_http.client Delete record with id 'asdf' from collection 'nimbus-preview' in bucket 'main-workspace' INFO 2022-06-07 20:20:39,322 kinto_http.client Patch collection 'nimbus-preview'...
Okay i'll close this
@ncalexan Hrmmm yes interesting.... Let me think about this for a minute and get back to you.
@ncalexan Okay yeah, I think the simplest solution for now is to inject `{defaultProfile: {}}` here https://github.com/mozilla/experimenter/blob/main/app/tests/integration/nimbus/utils/filter_expression.js#L19-L23 until we can find a more rigorous solution so at least you're not...
Anyways adding the `defaultProfile` key to the targeting context does indeed make the test pass, so until we can have a more rigorous validation against the background task process, this...
I'll bet that this is what's causing this https://sentry.prod.mozaws.net/operations/experimenter-prod/issues/17811821/?query=is%3Aunresolved