janmaterne
janmaterne
These changes might improve performance, but do you have a testsuite with validates that? Most of the changes are done on places which are rarely invoked in a build (without...
ivy-lierre.svg: - looks good - havent compared, I think asciidoc/images and doc/images are the same? - why this name? why not simply logo.svg? (ok, I see: ivy-lierre.png ...) But there...
Violations of the license header: * ivy-lierre.svg (missing, remove the generator comment) * IvyLogo (missing)
Still open are: IvyLogo.java JavaDoc of the parameters of IvyLogo(int width, int height) are bad ("ditto") test the report But a simple ivy:report didnt work, I changed build.xml:500 to use...
While I think you shouldnt find such swagger files in production, I like the idea for security tests while development.
When using Spring, why calling the factory and not letting Spring inject the mapper? ``` @ExtendWith(SpringExtension.class) class ProjectsMapperTest { @Autowired private ProjectsMapper projectsMapper; // no call to Mappers.getMapper() ```