Tomasz Janiszewski

Results 65 issues of Tomasz Janiszewski

Consider following tests. It's passing on 1.14.1 but fails on 1.14.2 with ``` # 1.14.2 Expected :{"_":[["-"]]} Actual :{"_":[[]]} ``` ```go package gjson import ( "testing" "github.com/stretchr/testify/assert" "github.com/tidwall/gjson" ) func...

When somebody links to this project on social media the default template is loaded. It will be great if we have logo and set of social media images that will...

discussion

https://github.com/laher/goxc is in maintenece mode. We used it to greate debs and versions for linux and mac but since we moved to fpm we can remove goxc from project with...

help wanted
hacktoberfest

It looks like our README is out of sync and hard to understand. We need to highlight assumptions and limitations of marathon-consul, provide clear and up to date [changelog](http://keepachangelog.com/en/0.3.0/) and...

We are using `ogier/pflag` because it was introduced in original [CiscoCloud](https://github.com/CiscoCloud/marathon-consul/blob/master/config/config.go#L8) project. pflag looks like abandoned (last commit over a year ago). We should switch to official golang flags. This...

help wanted

Marathon and Mesos allows specifying names for port. We should use this name to register service in Consul. We can remove `consul: ` label and keep only service tags in...

Marathon 1.4 introduces pods. This completely change approach to apps/tasks. Marathon no longer use apps/tasks in events but move to run specs and instances. Currently we do not support pods....

enhancement
question

With https://github.com/allegro/marathon-consul/pull/145 and https://github.com/allegro/marathon-consul/issues/164 we put a plaster on Marathon app task differences. We should obtain app definition for task in version defined in task. We can use `/v2/apps/{app_id}/versions/{version}` endpoint...

bug

Right now we have only synthetic tests that check how marathon-consul behave when it gets specific event form Marathon and how it interacts with Marathon and Consul then. Before merging...