James Muir

Instead of exercising the test vectors in `example-poly1305.c` I suppose this could be instead done inside `poly1305_power_on_self_test()`.

@floodyberry : just wondering if you will consider merging this PR. It has been open since 12 April.

The test vector for #507 is expected to cause a failure (i.e. fail is good). The reason it still fails when the fix is reverted/removed is because the ASN1 parser...

I think the primary vulnerability uncovered in #507 is not in utf-8 decoding; it is the underflow of the unsigned computation "*inlen -= len;" inside `src/pk/asn1/der/sequence/der_decode_sequence_flexi.c`. There should be an...

That does indeed appear to be a redundant check. Would you be able to open a PR with a fix?

I don't think opengapps has an "x86" or "x86_64" version of Phonesky (i.e. "com.android.vending"), which probably explains the "acp" error message. However, there are apks for "com.android.vending.leanback" in the "x86"...

You are going to have to experiment on your own a bit. I don't have all the answers :-) Note that I've never built android-x86. > I cannot find GooglePlayStoreLeanback...

> It did not help. I did exclude phonesky and add vendor/opengapps/build/modules/GooglePlayStoreLeanback/Android.mk. After you define a new module, you need to explicitly add it to your build. You should have...

> play store installed, but it is not the x86 version. opengapps provides two apks for com.android.vending.leanback. One is in the x86 project and the other is in the x86_64...

PR stands for "pull request". Start by forking the project https://github.com/opengapps/aosp_build into your own github account. Make whatever fixes you like and then push them up to your forked copy....