James Newton Taylor comments

Results 6 comments of


                                            James Newton Taylor

[Web] Use `withCredentails = true` by default

@kartercs see [my comment on related issue](https://github.com/dart-lang/http/issues/20#issuecomment-706208889) You don't need to store the cookie, just set it in the browser, but it will not work without `withCredentials = true` #20

[Web] Use `withCredentails = true` by default

I have put in pull request #485 to change the default setting in the browser client

HttpException stacktrace is lost when ClientException is thrown

This might lead to less people posting issues about CORS errors 😄

(BrowserClient) add constructor to set withCredentials value

I don't see how this is going to help, because the only reference to the constructor call is this global function: `BaseClient createClient() => BrowserClient();` ([lib/src/browser_client.dart - line 20](https://github.com/dart-lang/http/blob/a8efbef05a58919dc7aa2dab42198334f2459ffb/lib/src/browser_client.dart#L20)) So...

server side api has Cookie, please add to client side api

@greg-fischer I am also trying to implement security the "right" way using httpOnly cookies stored in the browser. When my HTTP response has 'set-cookie' in the header, the cookie is...

server side api has Cookie, please add to client side api

I have put in pull request #485 to change the default setting in the browser client