Jakub Grzegorzewski

Results 13 comments of Jakub Grzegorzewski

after using this for a bit, I think I may implement an optional `handler` fn instead of `hashRoutes` to avoid redundant index hash route definitions like `{'': (...) => {...}}`

I would like to add a test for this in client tests - but seems they don't actually run in CI. Any guidance would be much appreciated! https://github.com/databricks/databricks-sql-python/issues/317

> Thanks for this contribution. We have rather poor testing facilities for proxies at present (we need proper CI for this repository -- that's coming soon). Will review and perform...

commenting for visibility - we just noticed this as well and seems like a simple fix 🙏

Hey @dinesh-kumar-allen, as of 2.54.0 we started bundling the session recording module for the default NPM installation which will account for the increased bundle size. We've provided alternatives to import...

Hey thanks for the contribution! If I'm understanding correctly, the use case here is to be able to import the pre-built bundles like `import mixpanel from 'mixpanel-browser/dist/mixpanel-core'` and the types...

Hey! Thanks for tagging me, I should really turn on notifications. Looks like even accessing localStorage in safari errors out, we did not consider that. We'll get this fixed ASAP...

Hey, thanks for the report. Do the `opt_in_tracking` / `opt_out_tracking` methods not fit this use case? Session recording would probably need a major refactor to disconnect from persistent storage while...

Hey @bhamiltoncx - sorry this totally slipped my radar. Yes the correct approach is to use the opt_in/out functions.

Hey thanks for the report. We forked rrweb in the latest release (2.69.0) that should contain the fixes from the issue you mentioned 🙏 . Mind upgrading and letting us...