jakeprime

Results 4 comments of jakeprime

I think there is a potential issue here because `to_i` always rounds down. I do not know the exact process that creates the `iat`, but if it rounds both ways...

I've realised that the `maxAge` value was previously treated as being in milliseconds. However the spec states that it should be in seconds. [rfc6265](https://tools.ietf.org/html/rfc6265#section-4.1.2.2): > The Max-Age attribute indicates the...

@baloo Yes you're right, it doesn't make sense to change it to seconds now, I've reverted that. I see this has been discussed before (https://github.com/pillarjs/cookies/issues/65#issuecomment-163776899). I understand why it makes...

@dougwilson I believe this is a fully backwards-compatible change. There is no change in the way the cookie is set, and as far as I can tell the only functional...