James Ahlborn
James Ahlborn
yep, that does make for a more fluent api.
FYI, this is how i handled it: https://github.com/jahlborn/jmxterm/commit/6b62c323c620b7fb7772597d5f20b22375e41b27
@shshankar1 i'm not sure what you mean. is #50 somehow different than this issue? in my previous comment, i link to how i created an ERROR_ONLY verbosity level.
Yes, this would be very useful especially for "custom" licenses. Today, we are just including the url as part of the name, e.g. "project--1.0=Custom License - http://project/path". Maybe the license...
To confirm, yes we are referring to the THIRD-PARTY.properties file. And to reiterate what @simonklb said, this is desirable for custom licenses, e.g. jdom http://www.jdom.org/docs/faq.html#a0030 .
can you explain why you removed the explicit timezone? the point of the explicit timezone in the unit test is to _avoid_ failures when running in a different timezone.
> **DatabaseTest.testAncientDates** fails without my patch. Failure details: > > ``` > Tests run: 28, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.93 sec at junit.framework.Assert.failNotEquals(Assert.java:329) > at junit.framework.Assert.assertEquals(Assert.java:78)...
> > Updated pr and force pushed. Please take another look - thx. ah, that looks much better, thanks!
@spannm i incorporated those changes, although i went a slightly different direction with the locale settings (i was concerned that messing with the default locale might now work reliably in...
> > different direction with the locale settings (i was concerned that messing with the default locale might now work reliably in a multi-threaded setting) > > You're concerned about...