Jack Koenig

> Every chisel module has implict clock and reset Not strictly *every* module, `Module` and `MultiIOModule` have implicit clock and reset, but `RawModule` does not have implicit clock nor reset....

I'm a bit late here, but @drom asked this because I ran into it in FIRRTL Verilog emission. I think it's a reasonable test to add since it's easy to...

Yeah, you're right. Cats Effect and other libraries that provide an IO monad have ways of wrapping imperative snippets (not everything needs to be a for-comprehension), but the ability to...

Why do we need this instead of just letting CIRCT parse the `.fir` and `.anno.json`?

For implementing this, the basic problem is trying to deserialize a whole `List[Annotation]` at once: https://github.com/chipsalliance/firrtl/blob/ef1d27a84addc46353884eb06ea18f4c68e6a808/src/main/scala/firrtl/annotations/JsonProtocol.scala#L298 To do this, we need to deserialize one-by-one. This is basically the inverse of...

@davidbiancolin has noted that package-level allow and disallow lists may be useful here.

The diff for `RenameMap.scala` is an absolute disaster, it might be worth just looking at the new file, and maybe generating the API docs locally and taking a look.

I've rebased this on master but I'd like to hear from @davidbiancolin before I merge this. I **could** instead do the deprecation in 3.5.0-RC2. It's a bit harder from my...

@seldridge there's a conflict with the `.pdf` and it just got dropped from the PR. This will require a manual fixup.

I suspect these failures are false positives, running locally (and refactoring the script so that running locally is easier to do).