Jean Kieffer

Results 8 comments of Jean Kieffer

I didn't realize there was an open issue about this ! I just needed a quick hack as in the `acb_theta` module, the matrices will never be larger than 20x20....

> I guess you've seen from the CI that the `complex_plot` example program needs updating. > > In fact, is it worth breaking the existing interface of `acb_theta_all`? I think...

All right, I'm marking the PR as ready for review ! I finished implementing the todos from my first message (except that acb_theta_types.h doesn't exist anymore.) Additionally, I have rewritten...

> Hello Jean, and sorry for the delay! Is there anything specific that you'd like to have feedback on? No worries at all. I think the main questions I have...

> Can you make it more clear, or direct me on how to compute theta functions for specific ( a , b ) (or how to obtain them from `acb_theta_all`)?...

Hi @fredrik-johansson and @albinahlback , sorry for the delay as well. I tried to squash the older commits, down to 13 now. Do you think I should squash them more...

By the way, how should I squash commits that happened before a merge, say from https://github.com/flintlib/flint/pull/2182/commits/c45276fe08cd6a49067ec10425d75b35ffad776c to https://github.com/flintlib/flint/pull/2182/commits/9437e73a3fea13557962a41cff2c98cb5f9b7de2 ? `git rebase` forces me to solve the merge conflicts again, which...

Thanks for the bug report and sorry for the delay! Should be fixed by #2404