Ivan Zlenko comments

Results 5 comments of


                                            Ivan Zlenko

HDDS-11041. Add admin request filter for S3 requests and UGI support for GrpcOmTransport

General question: do we have any new tests for this?

HDDS-11041. Add admin request filter for S3 requests and UGI support for GrpcOmTransport

@devabhishekpal new filter could and should be covered with unit tests at least.

HDDS-11041. Add admin request filter for S3 requests and UGI support for GrpcOmTransport

Thanks @devabhishekpal for tiding up code!

HDDS-11041. Add admin request filter for S3 requests and UGI support for GrpcOmTransport

@devabhishekpal from my point of view should be enough to have unit tests with mocks to verify that the contract for the filter will remain the same with any changes...

HDDS-11040. Temporarily disable revoke/generate secret by name methods in REST

> One solution is to put the operations under their own endpoint like admin @errose28 secret endpoint is already separate from main S3G and can be disabled. Or you talking...