Maxim Ivanov

Results 13 comments of Maxim Ivanov

This issue do I have with the version in the develop branch. ``` $ git log --oneline -1 a8eb48e (HEAD -> develop, origin/develop, origin/HEAD) Merge pull request #165 from es80/develop...

Oh, `poetry` dropped support for Python 3.7, so it cannot be installed for 3.7 environment. Possible way forward: - Drop support for Python 3.7 in `classes`. Any plans to keep...

> I pushed a fix for this problem to `master`, please, rebase OK, thanks! I tried to fix it myself, but now I will rebase

It turns out that there are multiple mypy check failures with the newest mypy version. I tried to fix some of them, but it goes beyond my experience and knowledge...

> You can use older mypy for now, I will fix these issues later :) I reverted back to mypy v0.942, but surprisingly the errors persist (even more errors appeared)....

I revisited the issue once again. Now I can see that the syntax error is not visible anymore. Checked in Microsoft Edge and Firefox. It is likely that the issue...

> This project is a bit outdated, please, feel free to fix it / send a PR. Will do

> @ivanovmg, does you have any ideas, why on CI and locally tests completed, bot in rultor failed? @alchemmist no, it is not that clear to me. I added a...

> > @KachanovYev thank you for the PR! Please have a look at my comments. > > I also think that the PR title & description can be improved to...

> > @KachanovYev thank you for applying my suggestions! It looks good to me. I suggest that you change the title of the PR, though - ast.from_string is not relevant...