Will Anderson

Results 21 comments of Will Anderson

I'm actually working on updating my branch this week. The `webview-spec` tests got migrated to a different spec runner so I'm having to rewrite those, but once that's done I...

Rebased to get the CI fixes from #35593

Yes, it's ready for review now 🙂

Draft while I sort out some usage docs for the navigation events

> I _think_ this would supersede #323, so CC'ing @MarshallOfSound since he had opinions in that PR I don't think this PR currently solves the goals of that PR, but...

I've moved the `DEVELOPER_DIR` env var to `depot-tools.js` so now it should apply to any child processes spawned via that mechanism. @MarshallOfSound what would you think of me removing the...

TypeScript code would raise type errors if you tried to type those parameters with the old types, right? It would be pretty easy to update your callback to fix the...

If type definitions change in a way that's likely to require a code change to get TypeScript to compile, it doesn't seem unreasonable to treat that as a breaking change...

I left off this property because `will-frame-navigate` doesn't fire for in-page navigations, so it didn't seem like a useful property to expose. I have no strong objection to documenting the...