Mateusz

Results 9 comments of Mateusz

Hi @jonklein! Thank you for PR :) We will review it soon!

Hi @jonklein! First of all, we would like to thank you for your contribution! We discussed this matter and would like to propose another way to handle the codebase migration...

Hi @maxmarcon, thanks! The reason is simple - what we have to do now if we want to require the select to not be empty is; 1. Assign a variable...

Regarding the changsets for form - generally, yes, we do use. But this one is a bit more complicated, I would say, because we use interceptors (designed by our RAP...

Apologies for not being clear! - RAP - roles and permissions system - interceptors - https://hexdocs.pm/phoenix_live_view/Phoenix.LiveView.html#attach_hook/4 Sample LiveView (pseudocode) ```elixir def LiveView do use LiveView, :live_view on_mount(LiveView.Interceptors, {:create, :can_create}) def...

1. So, we are checking if the field was settled in the form - from this perspective, we **require** it to be settled. It is just needed for further checks...

Sorry for all of the confusion, @maxmarcon! So, my main argument for the `required` option would be just the ease of usage. As you correctly pointed, we can achieve the...

Hi @maxmarcon! What you mean is that all of the attrs provided by Phoenix will be supported by LiveSelect, right?

Hey @maxmarcon! Okay, that's what I thought initially! Yup, I would like to take care of that. Are you sure we need **all** of these attrs, though? 🤔 (if you...