SeungHoon Han

Results 15 comments of SeungHoon Han

@rom1v Thank you for quick response. Accessing VirtualDisplay restriced by UID or FLAG_PRIVATE, So It can return null object. `getDisplayInfoInternal(int displayId, int callingUid)` https://cs.android.com/android/platform/superproject/+/master:frameworks/base/services/core/java/com/android/server/display/DisplayManagerService.java;drc=f6247e3d3067fea526382ae32d83f6c650449589;l=633 `hasAccess(int uid, int flags, int ownerUid,...

> No, It doesn't fixed yet. It can cause conflict my code. So I will modify my commit and apply dev branch again.

I changed base branch from 'master' to 'dev'. please review again.

> Hi, > > Sorry for the delay. > > I reviewed, and took your branch and applied a few changes: > > * added `execReadOutput()` to keep `execReadLine()` as...

I added Pattern.MULTILINE option. It works.

Thank you. There is more something to check after Android API 31. https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/view/DisplayInfo.java;drc=db08ffe5f18f9335c07b367b740a94fa97206a80;l=729 In API31 emulator `dumpsys display` ``` mBaseDisplayInfo=DisplayInfo{"Built-in Screen", displayId 0", displayGroupId 0, FLAG_SECURE, FLAG_SUPPORTS_PROTECTED_BUFFERS, FLAG_TRUSTED, real 1080...

And I added testcase for No FLAG display.

> +1 > > I rebased on `dev`, and applied the following minor changes: > > * removed useless `?` after `.*` > * test `== null` first to avoid...

> @rom1v `.*` means Greedy quantifier. `.*?` means Lazy quantifier. see, https://javascript.info/regexp-greedy-and-lazy

I tested regex in https://regex101.com/r/8tpLez/1