Seungchan Ahn
(cc: @zaldanaraul) Hello @medikoo 👋 - The description sounds straightforward. Could you let me in?
In the [PR](https://github.com/serverless/serverless/pull/10067), we've found and listed broken test files after this change: - test/unit/lib/plugins/aws/package/compile/events/cloudFront.test.js - *already issued: https://github.com/serverless/serverless/issues/8528 - test/unit/lib/plugins/aws/package/compile/events/sqs.test.js - test/unit/lib/plugins/aws/package/compile/events/stream.test.js - test/unit/lib/plugins/aws/package/compile/events/websockets/lib/api.test.js - test/unit/lib/plugins/aws/package/compile/functions.test.js - already issued:...
@medikoo I'm glad to hear that! Thanks for cleaning them up. We got one more step closer to the end.
@medikoo Thank you for all this walking me through! I've just resolved all threads. Could you take a look again?
Thank you for the review. I've resolved every thread except the test one: @medikoo Could you let me know what do you mean by "tests in **CIN**"? I listed some...
Found how this branch is different from `master` and how it breaks the test > test/unit/lib/plugins/aws/deploy/index.test.js In this branch, we escape the `Resource` array having only one item, it makes...
> I think it's fine to do that, as this I believe introduces determinism. With this PR, single resource will never be wrapped into array. I believe the same. I...
For future ref. Another test in CI is failed for the same reason to above one. Will fix it in the same way. - test/unit/lib/plugins/aws/deploy/lib/checkForChanges.test.js:1078:60 - "should skip a deployment...
For future ref. Other tests in CI are failed for the same reason to above one. Will fix - test/unit/lib/plugins/aws/package/compile/events/activemq.test.js:81:86 - "when there are activemq events defined" - "should update...
I've updated tests-in-CI broken by unwarped `Statement.Resoiurce` policy. Now, in CI, we are facing broken tests that are not based on `runServerless`. As per the issue description, it's time to...