isidzukuri

Results 7 comments of isidzukuri

it requires additional testing by maintainers

@dacook please take a look https://github.com/openfoodfoundation/openfoodnetwork/pull/12496

Yes! Please update! related issue https://github.com/tumblr/tumblr_client/issues/55

$ ruby -v ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-linux] $ gem list **\* LOCAL GEMS *** actioncable (5.0.0) actionmailer (5.0.0, 4.2.6, 4.2.5, 4.1.10) actionpack (5.0.0, 4.2.6, 4.2.5, 4.1.10) actionview (5.0.0,...

Works if in Gemfile: ``` gem 'tumblr_client', git: 'https://github.com/tumblr/tumblr_client.git' ``` then ``` bundle install # Using tumblr_client 0.8.6 (was 0.8.5) from https://github.com/tumblr/tumblr_client.git (at master@a72b7f4) ```

ive tried to save only changed products https://github.com/openfoodfoundation/openfoodnetwork/pull/12515. But still, variants should be saved here https://github.com/openfoodfoundation/openfoodnetwork/blob/master/app/services/sets/product_set.rb#L107 . Simply put there `variant.changed?` would not help because it does not take into...

I will play the role of the opposition in this discussion :smile: events (pub/sub) != decoupling. Reasons described in "Benefits / Requirements" are leading to hiding coupling behind events, but...