Ignasi Pérez-Ràfols
Ignasi Pérez-Ràfols
I did not check the pk1d changes in a lot of detail, let me know when you are ready for me to do so. Also, on the changes of delta_extraction,...
@julienguy , this should fix your complaint the other day about not having the tile information in the delta files. Can you review that this is indeed what you needed?
is this ready for review?
Hi all, I modified the file so that it now uses functions already defined in dla_mask, instead of defining new functions that do the same things. @andreicuceu can you check...
I fixed the typo and added the lyman beta absorption, but tests are still missing
tests are failing due to a weird coveralls error. Maybe their server is down. Otherwise, they might have updated something and the new version is not backwards compatible. We should...
Hmmm I have never seen this before. It does indeed sound potentially problematic. We should check which are the offending forest(s) so that we can verify what is happening
Hi @andreufont , I fixed the comments on the code. Thanks! Regarding your question about the changes in the test suite, since I had to add a couple of keywords...
@andreufont , are you happy with the changes? should we merge this?
I fixed the bugs, but indeed we should fully test this (I have not had the time to properly do it)