ioworker0

Results 9 comments of ioworker0

This PR could introduce a problem. ```golang // The address of two struct{} values may be the same. var a, b struct{} fmt.Println(&a == &b) // true ``` ### My...

> @Mutated1994 thanks for your pointing out the potential bug for the stopArg definition > > I fixed to `var stopArg interface{} = &struct{ a byte }{}` and the test...

> **Just because the fact that we can do, doesn't mean we should do**. > > I'm afraid you'll have to prove that this PR is necessary for users, BTW,...

All of these changes that only apply to Linux. Will the other platforms be completed later?

> COMPAT=1 > 看来还需要对4.9的内核做一点适配。。。我以为4.X都支持nft呢 > > 你可以把DEFINE_KPROBE_SKB(nf_hook_slow, 0, 4)里面的用#if __KERN_MAJOR != 3圈起来的部分删掉,再编译 > > 这个我后面再适配吧 Hi bro @menglongdong I also encountered this issue on the 4.11.1-1.el7.elrepo.x86_64 kernel today, so I'd...

> 还有其他的问题,当我指定COMPAT=1编译时仍有下述错误 > > ``` > make clean > make -C src clean > make[1]: Entering directory '/home/ubuntu/workspace/nettrace/nettrace/src' > rm -rf nettrace trace_group.c progs/kprobe_trace.h \ > progs/kprobe progs/tracing progs/feat_args_ext progs/*.o...

> 4.9和4.11这两个版本之前没有做过适配性测试。不要急,我这两天抽空就做一下。 Cool, thanks!

> 最新的代码,4.9和4.11应该是都能正常运行了的,望悉知~ Nice work! I just confirmed that the latest version is working as expected on the 4.11.1-1.el7.elrepo.x86_64 kernel version ;) Thanks a lot for your time and effort!