Results 69 comments of Matteo Interlandi

Hi @klesouza, thanks for reporting this. Yes we don't support categorical values in lightgbm yet. +1 on the better reporting error. As a momentary workaround, once #244 is in, we...

This is actually a [bug](https://github.com/onnx/onnxmltools/issues/415) with ONNX converters \ runtime. Commenting out the test for the moment.

I was thinking about something similar today. It would be good to have some benchmarking refresh every time a new commit goes in. Perhaps we can store the benchmark numbers...

Yes, we can put all the scripts into a `benchmark` directory. Do you know how other projects deals with performance regression in an (semi-)automatic way?

I am starting with pushing the code for the benchmarks. The tasks to complete this PR will be: - [ ] Trees [#315] - [ ] Operators [#316] - [...

Actually you can take a look at count vectorizer code at [this](https://github.com/microsoft/hummingbird/tree/mainterl/wipcountvectorizer) old branch.

I made no changes, let me delete mine then since it is not used.

Please! Having tf-idf will be fantastic. Can you please open as issue specific for tf-idf so that we can discuss on the implementation? I don't think it will be super...

Thanks @arfangeta for reporting this. Yes this is is supposed to work. I will look at it.

Hi @arfangeta, how are you calling the converter? I added a test for you code above and it works (#238).