Andreas Klöckner

Results 957 comments of Andreas Klöckner

I don't know that I love this, because pretty much by definition, we'll have redundant meshes flying around, which seems avoidable. First of all, could you remind me where those...

Could you explain the reason for that normalization step? Why is it needed? (I'm not suggesting that it isn't, I'm just not currently understanding.)

Still sort of puzzled, sorry. Let's talk about it during our meeting tomorrow.

As discussed during meeting: We'll leave this open, but for now the creation of duplicate meshes seems avoidable by checking if the normalization step is a no-op.

Those are not the failures it's complaining about, though.

> currently the context factory only works with a PyOpenCLArrayContext What's a context factory? Sorry if I'm being dense.

We could potentially parametrize that, like so: ```py from functools import partial def pytest_generate_tests_for_cl_array_context(context_from_cl_device, metafunc): pytest_generate_tests_for_pyopencl_array_context = partial(pytest_generate_tests_for_cl_array_context, ArrayContextFactory) ``` Also, there's no need to copy-paste whole chunks of code....

One problem I see here is that human-readable names (e.g. `wall_block`) occur only in lines that are technically comments. How important is it that these names are preserved? https://victorsndvg.github.io/FEconv/formats/bdf/MD_Nastran_2006_Quick_Reference_Guide.pdf

(Compared to just the property numbers, i.e. the things defined by `PROD` et al.)

@lukeolson and I discussed that a bit a few years ago, and at the time - we didn't need it because Gmsh covered our needs, and - Nico Schloemer (sp?),...