Simon Frei

Results 295 comments of Simon Frei

Should there be a flag/config option for this? There could be projects interested in coverage of generated code.

Can that be tagged such that the module can be imported cleanly?

This project is absolute great. It allows to get rid of soooo much boilerplate, that I needed to update too frequently. And opens easy access to more detailed testing -...

Looks very useful. Just a general remark on UI: I'd put it into it's own modal/actions menu item - under logs it's not very discoverable. Or maybe putting it in...

> The current name of the modal, i.e. "Logs", isn't exactly correct right now already, as it contains both logs and debugging, so I think it'd fit well. Just my...

> I like the idea of replacing the "Support Bundle" link. However, it took me some time to even find information about it, because it is hidden unless the Debugging...

> Not sure what the Windows build failure is trying to tell me, I haven't touched the `autoClosedFile` stuff AFAICT. It's telling you nothing, it's flaky.

> I'm not opposed to switching to a structure type of some kind, but I don't yet see how it will change the fundamental pattern of parse args - override...

> I think this is done, please review. Do we want to keep the `paths` property in `/rest/system/status` as well or only on its own endpoint? What's the purpose of...

I was questioning having it in both. Personally I'd probably go for simplicity over granularity/optimisation given the existing `/rest/system` endpoint (containing static info already), but I don't feel strongly either...