Tyler Ang-Wanek
Tyler Ang-Wanek
Would you kindly take this issue upstream to libgit2?
That would be ideal. Using an up-to-date ecma standard for our examples would be awesome.
We'll get this addressed in 0.28.0.
Yes. So when we developed this, we originally did show merge commits, but for some reason or another, that was shot down from one of the main NodeGit crowd so...
Took a little more time to digest what you're saying. I think your approach of diffing parents until we can prove there is no file change in a merge commit...
Hmm, so I did some playing around with this today. I think maybe we should just try removing the skip merge commits statement all together. We will have the merge...
This doesn't seem correct. Instead we should kill the getTree function and correct the descriptor for the git_commit_tree generated code. @rcjsuen
@rafaelgieschke Any chance you can fix the conflicts? I'd like toget this into the codebase.
Axosoft is aware that we need to update this shortly. We'll be putting 2 engineers on this after our next GitKraken release. We want to hit this before Electron 11...
An update: I'm starting work on this officially. I am currently working on making sure that I'm not going to back myself into a corner by moving to N-API. There...