Quentin Peter
Quentin Peter
Looks like pdb is quite slow in Mac tests / Mac - Py3.9, conda, fast ?
Maybe we should just skip `test_ipythonconsole.py` on mac? What do you think @ccordoba12?
@ccordoba12 I am not sure why this was failing yesterday, but this should be delt with before 8/30/2022: > the image will be fully unsupported by 8/30/2022
@ccordoba12 Should we use Mac 12 or Mac 11?
@ccordoba12 the `test_completions_environment` seems to be very flaky (Only runs on windows), I think this is unrelated to this PR
That seems to be addressed by the latest commit
Ok so I had a look and think we should do the following: There are two decorators for requests: `@schedule_request(method=CompletionRequestTypes.DOCUMENT_COMPLETION)` `@request(method=CompletionRequestTypes.DOCUMENT_COMPLETION)` The first one schedules a request to be made...
So to summarize, there are two subjects: 1 - LSP requests: Most LSP requests are not time sensitive (It doesn't matter if the errors take a little while to show)...
I think the main question is: would you rather send many unnecessary requests or wait an extra 300ms to send the requests. > That's a good idea and would avoid...
@ccordoba12 The same approach can be used for merging 5.x in master